Feature - Validate Shelter Certificate #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogargon
reviewed
Apr 4, 2024
|
|
||
| Scenario: Validating a incorrect shelter certificate | ||
| Given a shelter certificate associated with a shelter with name "test" with invalid information created by a shelter volunteer | ||
| Then the admin with username "admin" and password "123456789" rejects the certificate validity associated with a shelter with name "test" |
There was a problem hiding this comment.
Shouldn't this be a When and not a Then? And, accordingly, in the implementation of this step use the API to make some sort of update of the state of the certificate (beyond just reading it)?
There was a problem hiding this comment.
Solved the feature definition and improved the step implementation.
jorgechp
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.